[Tests-Only] Add acceptance tests for enforced expiration on collaborators share #3159

kiranparajuli589 · 2020-03-06T11:08:24Z

Description

Acceptance test added for enforced expiration date on a user/group share

Related Issue

Part of More tests for collaborators expiration date #3132

Motivation and Context

How Has This Been Tested?

locally

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

...

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js

jasson99

LGTM

tests/acceptance/stepDefinitions/sharingContext.js

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js

dpakach

LGTM 👍

tests/acceptance/stepDefinitions/sharingContext.js

tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature

tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature

haribhandari07

LGTM

individual-it · 2020-03-16T05:05:13Z

tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature

+    And the setting "shareapi_enforce_expire_date_user_share" of app "core" has been set to "yes"
+    And the setting "shareapi_expire_after_n_days_user_share" of app "core" has been set to "5"
+    And user "user1" has logged in using the webUI
+    When the user tries to share file "<shared-resource>" with user "User Two" which expires in "+6" days using the webUI


Suggested change

When the user tries to share file "<shared-resource>" with user "User Two" which expires in "+6" days using the webUI

When the user tries to share the resource "<shared-resource>" with user "User Two" which expires in "+6" days using the webUI

should not say file, because one of the examples is a folder

individual-it · 2020-03-16T05:07:14Z

tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature

+      | simple-folder   |
+
+  @issue-3174
+  Scenario Outline: user cannot share with user with expiration date within set enforced maximum date if default expiry date for both user and group is enabled


Suggested change

Scenario Outline: user cannot share with user with expiration date within set enforced maximum date if default expiry date for both user and group is enabled

Scenario Outline: enforced expiry date for groups does not affect user shares

Need also a test for the other direction

individual-it · 2020-03-16T05:09:37Z

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js

 const { client } = require('nightwatch-api')
 const collaboratorDialog = client.page.FilesPageElement.SharingDialog.collaboratorsDialog()
 const SHARE_TYPE_STRING = {
  user: 'user',
  group: 'group',
  federation: 'remote'
 }
+const COLLABORATOR_PERMISSION_ARRAY = sharingHelper.COLLABORATOR_PERMISSION_ARRAY


individual-it · 2020-03-16T05:09:45Z

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js

@@ -1,13 +1,14 @@
 const util = require('util')
 const _ = require('lodash')
-const { COLLABORATOR_PERMISSION_ARRAY } = require('../../helpers/sharingHelper')
+const sharingHelper = require('../../helpers/sharingHelper')


individual-it · 2020-03-16T05:11:58Z

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js

-        .expirationDatePicker()
-        .setExpirationDate(days)
+      const dateToSet = sharingHelper.calculateDate(days)
+      const expectToSucceed = await this


variable name does not make sense, how does setExpirationDate know what is expected?

individual-it · 2020-03-16T05:13:38Z

tests/acceptance/stepDefinitions/sharingContext.js

@@ -1009,3 +1016,28 @@ Then('the fields of the {string} collaborator for file/folder/resource {string}
 Then('user {string} should have received a share with target {string} and expiration date in {int} day/days', function (user, target, days) {
  return checkReceivedSharesExpirationDate(user, target, days)
 })
+
+Then('the expiration date input field of collaborators form should have value with {string} days on the webUI',


Suggested change

Then('the expiration date input field of collaborators form should have value with {string} days on the webUI',

Then('the expiration date shown on the webUI should be {string} days',

individual-it · 2020-03-16T08:15:01Z

tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature

+    And the setting "shareapi_expire_after_n_days_user_share" of app "core" has been set to "10"
+    And the setting "shareapi_expire_after_n_days_group_share" of app "core" has been set to "5"


should be the other way around

dpakach

LGTM 👍

kiranparajuli589 self-assigned this Mar 6, 2020

kiranparajuli589 requested review from haribhandari07, dpakach and jasson99 and removed request for haribhandari07 March 6, 2020 11:09

kiranparajuli589 force-pushed the change-enforced-expiration branch from 1217f90 to 4430f33 Compare March 10, 2020 03:37

kiranparajuli589 commented Mar 10, 2020

View reviewed changes

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Outdated Show resolved Hide resolved

kiranparajuli589 force-pushed the change-enforced-expiration branch 7 times, most recently from 8468f05 to f906430 Compare March 12, 2020 08:07

kiranparajuli589 marked this pull request as ready for review March 12, 2020 08:10

kiranparajuli589 requested a review from DeepDiver1975 as a code owner March 12, 2020 08:10

kiranparajuli589 commented Mar 12, 2020

View reviewed changes

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Show resolved Hide resolved

jasson99 reviewed Mar 12, 2020

View reviewed changes

kiranparajuli589 force-pushed the change-enforced-expiration branch from 194d865 to d051832 Compare March 12, 2020 08:44

kiranparajuli589 requested review from individual-it and removed request for DeepDiver1975 March 12, 2020 08:58

kiranparajuli589 added Status:Needs-Review Needs review from a maintainer dev:acceptance-tests labels Mar 12, 2020

kiranparajuli589 mentioned this pull request Mar 12, 2020

user and group expiration dates do influence each-other #3174

Closed

haribhandari07 reviewed Mar 12, 2020

View reviewed changes

tests/acceptance/stepDefinitions/sharingContext.js Outdated Show resolved Hide resolved

kiranparajuli589 force-pushed the change-enforced-expiration branch 2 times, most recently from c955ea7 to 351d6de Compare March 13, 2020 06:18

kiranparajuli589 commented Mar 13, 2020

View reviewed changes

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Show resolved Hide resolved

kiranparajuli589 force-pushed the change-enforced-expiration branch from 351d6de to 46301da Compare March 13, 2020 06:30

dpakach reviewed Mar 13, 2020

View reviewed changes

tests/acceptance/stepDefinitions/sharingContext.js Outdated Show resolved Hide resolved

tests/acceptance/stepDefinitions/sharingContext.js Outdated Show resolved Hide resolved

kiranparajuli589 requested review from dpakach, jasson99 and haribhandari07 March 13, 2020 09:13

jasson99 reviewed Mar 13, 2020

View reviewed changes

tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature Outdated Show resolved Hide resolved

tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature Outdated Show resolved Hide resolved

jasson99 reviewed Mar 13, 2020

View reviewed changes

tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature Outdated Show resolved Hide resolved

kiranparajuli589 force-pushed the change-enforced-expiration branch 2 times, most recently from 9a62d92 to 0e02685 Compare March 13, 2020 10:21

haribhandari07 reviewed Mar 16, 2020

View reviewed changes

individual-it requested changes Mar 16, 2020

View reviewed changes

haribhandari07 force-pushed the change-enforced-expiration branch from 0e02685 to a713423 Compare March 16, 2020 07:05

haribhandari07 requested a review from individual-it March 16, 2020 07:07

individual-it requested changes Mar 16, 2020

View reviewed changes

haribhandari07 force-pushed the change-enforced-expiration branch 2 times, most recently from 6025297 to 82c2ed9 Compare March 16, 2020 10:18

Added acceptance tests for enforced expiration on collaborator shares

c723f81

haribhandari07 force-pushed the change-enforced-expiration branch from 82c2ed9 to c723f81 Compare March 16, 2020 11:09

dpakach reviewed Mar 17, 2020

View reviewed changes

individual-it approved these changes Mar 17, 2020

View reviewed changes

individual-it merged commit 2e2c93b into master Mar 17, 2020

delete-merged-branch bot deleted the change-enforced-expiration branch March 17, 2020 06:15

LukasHirt mentioned this pull request Apr 9, 2020

More tests for collaborators expiration date #3132

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tests-Only] Add acceptance tests for enforced expiration on collaborators share #3159

[Tests-Only] Add acceptance tests for enforced expiration on collaborators share #3159

kiranparajuli589 commented Mar 6, 2020 •

edited

Loading

jasson99 left a comment

dpakach left a comment

haribhandari07 left a comment

individual-it Mar 16, 2020

individual-it Mar 16, 2020

individual-it Mar 16, 2020

individual-it Mar 16, 2020

individual-it Mar 16, 2020

individual-it Mar 16, 2020

individual-it Mar 16, 2020

individual-it Mar 16, 2020

dpakach left a comment

	When the user tries to share file "<shared-resource>" with user "User Two" which expires in "+6" days using the webUI
	When the user tries to share the resource "<shared-resource>" with user "User Two" which expires in "+6" days using the webUI

	Scenario Outline: user cannot share with user with expiration date within set enforced maximum date if default expiry date for both user and group is enabled
	Scenario Outline: enforced expiry date for groups does not affect user shares

	Then('the expiration date input field of collaborators form should have value with {string} days on the webUI',
	Then('the expiration date shown on the webUI should be {string} days',

		And the setting "shareapi_expire_after_n_days_user_share" of app "core" has been set to "10"
		And the setting "shareapi_expire_after_n_days_group_share" of app "core" has been set to "5"

[Tests-Only] Add acceptance tests for enforced expiration on collaborators share #3159

[Tests-Only] Add acceptance tests for enforced expiration on collaborators share #3159

Conversation

kiranparajuli589 commented Mar 6, 2020 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

jasson99 left a comment

Choose a reason for hiding this comment

dpakach left a comment

Choose a reason for hiding this comment

haribhandari07 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpakach left a comment

Choose a reason for hiding this comment

kiranparajuli589 commented Mar 6, 2020 •

edited

Loading